RSS Overhaul - #320
Conversation
|
Download the artifacts for this pull request: |
| // inconsistent orbital elements. | ||
|
|
||
| !Body,* {} | ||
| !Body,*{} |
There was a problem hiding this comment.
This bothered me when I saw it. Still does. It is critical that this patch runs before all other patches that add a Body node. Previously it relied on the lexicographical ordering: RealSolarSystem/RSSKopernicusSettings.cfg before RealSolarSystem/RSSKopernicus/. The "/" sorting after A-Z.
You don't have that pattern now. You have Config/RSS_Kopernicus.cfg compared with Config/Earth/. I didn't think MM patch ordering had a file-before-folder pattern, I thought it was strictly lexicographical.
My suggestion is move this patch to BEFORE[RealSolarSystem], making it clear and giving you a more obvious sorting of this setup patch versus the global ones.
There was a problem hiding this comment.
That is a very valid point and it should be a BEFORE pass even without name shorting (stock KSP mods use AFTER[Kopernicus] for example).
There was a problem hiding this comment.
As of 2239a63 a better MM pass is implementated. The new pass allows base RSS patches (celestial bodies), RSS general patches (CommNet etc) and RSS compatibility patches to coexist without conflicts.
|
If anyone around here is knownledgable about how textures are set up for use in KSP please do chime in. The terrain detail textures RSS includes have a very shiny-like, almost glossy appearance, which is...suboptimal. |
|
As weird as it sounds, no! 100% drop-in replacement. Well, the Titan body configuration had a duplicate GM factor with less precision that overrode the proper one so there might be a very slight difference in the orbit (8.978138376543E+12 vs 8.9778648E+12, 0.00305%). Edit 1: I could make a save-breaking change by reordering the body indices. Edit 2: OK, I will break saves, I corrected the height offset of Vesta and Ceres when transitioning between PQS/SS (any landed vessels will float above the surface). |
|
If it is save breaking, then AssemblyInfo.cs can/should probably be updated as well. It's still reading 18.5.0.0! |
|
I guess so, I am not well-versed with the C# side of KSP and mods (and should be done in a separate commit). |
|
Poll: since there will be some save-breaking changes, would this be a good opportunity to remove all "flightGlobalsIndex" definitions? |
|
There's different levels of save breakage. Pretty much nobody's going to care about vessels landed on Ceres. However every probe around every body getting deleted is a serious issue. |
|
For the above changes add the following textures: https://github.com/PhineasFreak/RSS-Textures-Dev/releases/tag/v0.1.0 Select your pack according to the already installed RSS textures. Replace when asked. |
- Let them match between standard and fallback shaders.
- Deprecate the use of fixed light settings in favor of the much more flexible light curves.
Before it was relative to the ecliptic but the inclination of satellites should be referenced to the parent body.
Adds some variety to these bland bodies...
Add the names of the new Enceladus and Triton biomes.
Minimum loading distance and collision meshes have been fixed. Size distribution TBE.
BurstPQS now allows higher PQS resolution to be achieved and with better performance. Further increases TBT.
- Move all CB textures to their own folders (necessary if asset bundles are implemented in the future). - Fix PQS detail textures specular brightness and blending level distances. - Add the new Enceladus and Triton biomes. These changes require the use of the new RSS-Textures-Dev packages!
- Updated the Charon osculating elements and fixed its relative inclination to Pluto. - Updated the Pluto initial rotation to match the proper orientation.
All four moons now have Jupiter as a reference and not the ecliptic.
- Everything now is referenced to the equator of Saturn instead of the ecliptic. - Update/fix all orbital elements.
- Everything now is referenced to the equator of Uranus instead of the ecliptic. - Update/fix all orbital elements. - Add unique orbital line colors.
Generally very minor changes except for the LAN (why so different?)
- This was an automated action, beep boop...
- Specify the missing end time and coordinate systems used for the JPL HORIZONS interface. - Add the original RSS osculating elements how-to guide link.
- Reset all biome science value multipliers to 1 (looks like they never worked in the first place - Kopernicus/Kopernicus#914). - Convert more missed COLORKEY fields.
Patch instead of inserting the new settings to keep everything in the MM cache in one place (debug-related, no user-facing changes).
For testing purposes only!
They are not needed anymore.
|
https://github.com/KSP-RO/RealSolarSystem/blob/restructure/Source/Watchdogs.cs Should be updated if the clip plane stuff is no longer in |
Major update for RSS to try and bring it up to current KSP/Kopernicus standards and fix some bugs:
Bug Fixes:
Known Issues:
Other Notes: